-
Notifications
You must be signed in to change notification settings - Fork 471
Description
Valid Title
- I have updated the title to accurately reflect the bug description
Description
Found during the testing of reviewer implementation of tasks and discussions. When a disclosed author reviewer is added it throws a haystack error (see screenshot below)
Steps to Reproduce
- Prerequisite - Must have a reviewer with diclosed author review type that has accepted the review opportunity
- Login with any role JM/JE admin
- Navigate to a submission in review
- Add discussion
- Fill in discussion form (title, comment etc..)
- In the participants list choose the disclosed author reviewer and any other non reviewer participants
- Select Save
Expected Result
Should save and add the discussion or task
Actual Result
Throws an error.
Environment Details
No response
Application Version
OJS 3.6 with task and discussons option on
Logs
[Fri Jan 09 19:26:55.756393 2026] [php:notice] [pid 75905] [client 99.240.110.28:63992] TypeError: in_array(): Argument #2 ($haystack) must be of type array, int given in /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/api/v1/submissions/tasks/formRequests/EditTask.php:144\nStack trace:\n#0 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/api/v1/submissions/tasks/formRequests/EditTask.php(144): in_array()\n#1 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/ClosureValidationRule.php(63): PKP\API\v1\submissions\tasks\formRequests\EditTask->PKP\API\v1\submissions\tasks\formRequests\{closure}()\n#2 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/ClosureValidationRule.php(63): Closure->__invoke()\n#3 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/Validator.php(902): Illuminate\Validation\ClosureValidationRule->passes()\n#4 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/Validator.php(678): Illuminate\Validation\Validator->validateUsingCustomRule()\n#5 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/Validator.php(481): Illuminate\Validation\Validator->validateAttribute()\n#6 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/Validator.php(516): Illuminate\Validation\Validator->passes()\n#7 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Validation/ValidatesWhenResolvedTrait.php(31): Illuminate\Validation\Validator->fails()\n#8 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/Providers/FormRequestServiceProvider.php(30): Illuminate\Foundation\Http\FormRequest->validateResolved()\n#9 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Container/Container.php(1432): Illuminate\Foundation\Providers\FormRequestServiceProvider->Illuminate\Foundation\Providers\{closure}()\n#10 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Container/Container.php(1368): Illuminate\Container\Container->fireCallbackArray()\n#11 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Container/Container.php(1354): Illuminate\Container\Container->fireAfterResolvingCallbacks()\n#12 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Container/Container.php(850): Illuminate\Container\Container->fireResolvingCallbacks()\n#13 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Container/Container.php(763): Illuminate\Container\Container->resolve()\n#14 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/ResolvesRouteDependencies.php(92): Illuminate\Container\Container->make()\n#15 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/ResolvesRouteDependencies.php(51): Illuminate\Routing\CallableDispatcher->transformDependency()\n#16 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/CallableDispatcher.php(52): Illuminate\Routing\CallableDispatcher->resolveMethodDependencies()\n#17 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/CallableDispatcher.php(40): Illuminate\Routing\CallableDispatcher->resolveParameters()\n#18 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Route.php(244): Illuminate\Routing\CallableDispatcher->dispatch()\n#19 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Route.php(215): Illuminate\Routing\Route->runCallable()\n#20 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Router.php(808): Illuminate\Routing\Route->run()\n#21 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(170): Illuminate\Routing\Router->Illuminate\Routing\{closure}()\n#22 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/classes/middleware/HasRoles.php(75): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#23 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): PKP\middleware\HasRoles->handle()\n#24 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/classes/middleware/HasContext.php(35): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#25 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): PKP\middleware\HasContext->handle()\n#26 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/classes/middleware/HasUser.php(35): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#27 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): PKP\middleware\HasUser->handle()\n#28 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(127): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#29 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Router.php(807): Illuminate\Pipeline\Pipeline->then()\n#30 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Router.php(786): Illuminate\Routing\Router->runRouteWithinStack()\n#31 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Router.php(750): Illuminate\Routing\Router->runRoute()\n#32 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Routing/Router.php(739): Illuminate\Routing\Router->dispatchToRoute()\n#33 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/classes/handler/APIHandler.php(104): Illuminate\Routing\Router->dispatch()\n#34 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(170): PKP\handler\APIHandler->PKP\handler\{closure}()\n#35 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/classes/middleware/PolicyAuthorizer.php(111): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#36 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): PKP\middleware\PolicyAuthorizer->handle()\n#37 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#38 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php(31): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle()\n#39 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(209): Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull->handle()\n#40 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()\n#41 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(51): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle()\n#42 /var/www/91.99.202.113.sslip.io/ojs/pr-5222/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Pipeline/Pip
Additional Information
No response
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Status