Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commits Bug]: missing category prefix incorrectly triggers #716

Open
1 task done
Kangie opened this issue Nov 21, 2024 · 2 comments
Open
1 task done

[Commits Bug]: missing category prefix incorrectly triggers #716

Kangie opened this issue Nov 21, 2024 · 2 comments
Labels

Comments

@Kangie
Copy link

Kangie commented Nov 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

For commit beginning

dev-lang/rust{,-bin}: Add 1.54.0

Receive

BadCommitSummary: commit 78526f93525c, summary missing 'dev-lang' category prefix: 'dev-lang/rust{,-bin}: Add 1.54.0'

Expected Behavior

This contains the prefix dev-lang; no error.

master commit id

N/A; trivial to reproduce

HEAD link

Trivial reproducer

pkgcheck version

pkgcheck 0.10.31

pkgcore version

pkgcore 0.12.28

git remotes configuration

origin git+ssh://[email protected]/repo/gentoo.git (fetch)
origin git+ssh://[email protected]/repo/gentoo.git (push)

@Kangie Kangie added the bug label Nov 21, 2024
@arthurzam
Copy link
Member

Well, I don't think we have in python a safe way to expand such texts, and I'm afraid to implement it, since it has high chance of mistakes in logic.

Considering this is just a message you can ignore because you know that you are correct, I'm more on the side of WONTFIX. But I'm open for more ideas or stances, so I am not closing still the bug.

@Kangie
Copy link
Author

Kangie commented Nov 23, 2024

It seems to know that we need 'dev-lang', it's just not picking up that it's in the summary. What about a simpler category in summary string comparison to catch this if the warning is triggered?

I don't actually mind the warning too much; if we decide to accept it we now have a ticket documenting that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants