Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT not usable for externals? #134

Open
mmanciop opened this issue Sep 17, 2020 · 4 comments
Open

PUT not usable for externals? #134

mmanciop opened this issue Sep 17, 2020 · 4 comments

Comments

@mmanciop
Copy link

mmanciop commented Sep 17, 2020

I am automatic the creation of a tile release on VMware Tanzu network, and while the put step works, the following (unavoidable?) get step fails because apparently I need to accept the EULA for for my very own release I just created.

2020/09/17 08:09:00 PivNet Resource version: 2.0.1
2020/09/17 08:09:00 Creating download directory: /tmp/build/get
2020/09/17 08:09:00 Getting release for product slug: 'instana-microservices-application-monitoring' and product version: '1.186.0'
2020/09/17 08:09:01 Accepting EULA for release with ID: 743234
ERROR: user with email '[email protected]' has not accepted the current EULA for release with 'id'=743234. Please manually accept the EULA via this URL: https://network.pivotal.io/products/313/releases/743234/eulas/193

Issue #74 seems to imply that this is expected behaviour, however Kafka-esque and frustrating (days of work sank into getting this far :D) it is.

I have looked for ways to ignore the error, but since the get is implicit, I could not find a way to ignore that error, without also ignoring errors on put.

Any ideas?

@mmanciop
Copy link
Author

In the README.md I found:

You will be required to accept a EULA for any product you're downloading for the first time, as well as if the terms and conditions associated with the product change.

I understand why it is like this generally in terms of legal implications, but I cannot believe that someone considered the use-case of "I am uploading my own release" and said "Yeah, you gotta accept that EULA too!" :D

@mmanciop
Copy link
Author

It frankly would be even fine with me to have a way to skip the implicit get, the put succeeding is enough indication of success.

@jtarchie
Copy link

The get step is implicitly done be Concourse, the resource has no control over that.

@mmanciop
Copy link
Author

Would it be possible to a "accept-eula" logic to the put or a "skip-eula" to get (if Pivnet allows)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants