You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current implementation of the UpgradeEntrypoint interface, the height parameter in both the SoftwareUpgrade event and the planUpgrade function is defined as an int64. I suggest changing this type to uint64 for the following reasons:
The block height is always non-negative, so int64 is unnecessary and could cause confusion.
The processing logic already treats any height less than or equal to zero as an error (ref. link).
Using uint64 makes the code clearer and safer by explicitly indicating that only non-negative values are allowed.
Suggested solution
Change int64 to uint64
Definition of done
Update related Solidity codes.
Deploy the new UpgradeEntrypoint
The text was updated successfully, but these errors were encountered:
Description and context
In the current implementation of the UpgradeEntrypoint interface, the height parameter in both the SoftwareUpgrade event and the planUpgrade function is defined as an
int64
. I suggest changing this type to uint64 for the following reasons:Suggested solution
Change
int64
touint64
Definition of done
The text was updated successfully, but these errors were encountered: