Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(evmstaking/keeper): add test cases for msg server #70

Merged

Conversation

zsystm
Copy link
Collaborator

@zsystm zsystm commented Aug 29, 2024

Increase test coverage of https://github.com/piplabs/story/blob/main/client/x/evmstaking/keeper/msg_server.go from 0% to 95.5%.

issue: close #64

@zsystm zsystm self-assigned this Sep 2, 2024
@limengformal limengformal changed the title test(evmstaking/keeper): add test cases for msg_server test(evmstaking/keeper): add test cases for msg server Sep 2, 2024
@limengformal
Copy link

@zsystm Can we rebase it so we can merge?

@zsystm zsystm force-pushed the zsystm/test/evmstaking/keeper/msg_server branch from cf04687 to 2b4e09a Compare September 5, 2024 04:59
@zsystm
Copy link
Collaborator Author

zsystm commented Sep 5, 2024

@zsystm Can we rebase it so we can merge?

@limengformal
Sure, I have rebased it. During the rebase, I moved the common helper function setupValidatorAndDelegation to keeper_test.go. This is the only change from the code you reviewed.

@limengformal limengformal merged commit 40076af into piplabs:main Sep 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage of evmstaking module
2 participants