Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstallTool RPC method for PluginService #5218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 19, 2024

What this PR does / why we need it:

With pipedv1's plugin architecture, we have to provide a way to install the tool used in the plugin.
I considered the following ways and propose the first way.

  1. provide InstallTool RPC at the PluginService.
  2. provide the directory path to the plugins in which the tool should be installed
  3. provide nothing to the plugins, and the plugin does all of the installation, such as making the temp dir to install the tool, ...etc

I propose the first way because we should consider multiple plugins that want to install the same tool/version at the same time.
In such a situation, we should prevent race conditions, and we can handle this with a sync.Mutex or something similar in the first way.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.82%. Comparing base (0e7a177) to head (c116f55).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5218   +/-   ##
=======================================
  Coverage   22.82%   22.82%           
=======================================
  Files         420      420           
  Lines       45309    45309           
=======================================
  Hits        10340    10340           
  Misses      34173    34173           
  Partials      796      796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only v1 is affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants