Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch Proposal: Default Schema Support #1366

Open
alexgann opened this issue Nov 9, 2023 · 1 comment
Open

Patch Proposal: Default Schema Support #1366

alexgann opened this issue Nov 9, 2023 · 1 comment

Comments

@alexgann
Copy link

alexgann commented Nov 9, 2023 •
edited
Loading

Video Demo of Feature: https://youtu.be/w0z4pU_E0bM

Issue

QueryBook QueryEditor is unaware of QueryEngine Connection URI's Default/Named DB/Schema

Resolution (see video for walkthrough):

  1. Add simple get_default_schema method to QueryEngine python model to parse any provided default schema on the connection URI
  2. Make this defaultSchema known to the front-end for Linting, Analysis, and AutoCompletion
  3. Retain support for use statements and explicit schemas when needed, and no-op to implicit "default" schema name when not provided

If this looks/seems reasonable I'll get a draft PR submitted for technical review.
Thanks!
@alexgann alexgann mentioned this issue Nov 29, 2023
Closed
@jczhong84
Copy link
Collaborator

@alexgann thanks for the proposal, this seems pretty useful! please feel free to post a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexgann @jczhong84