Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Make tiflash compatible with the cse branch #9765

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

*: Make tiflash compatible with the cse branch #9765

wants to merge 12 commits into from

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jan 6, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9767

Problem Summary:

What is changed and how it works?

The following adoption of cse only enable when SERVERLESS_PROXY = 1 is defined

  • Length of short value in lock CF encode as varInt instead of u8
  • Blocklist feature
    • keyspace blocklist
    • region_id blocklist
    • store_id blocklist under disagg arch
  • mtls
  • A HTTP API for Acquiring the all the region ids created in this TiFlash node with given keyspace id
  • File-base large txn
  • Special threshold on parallel prehandle

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Jan 6, 2025
@JaySon-Huang
Align the diff of short value in lock cf under cse
5632a14 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Add ut
feda366 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Add blocklist feature
254e2fb 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
fix blacklist-file args to proxy
7c46643 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Add http api for cse
2db71b8 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
mtls: metrics server allows anonymous pullers
4195065 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Enlarge the max parall prehandle size
4fff97b 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
txn-file: support txn file feature with cse
78104f1 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Fix parallel prehandle limit
92b36b1 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Fix lint
e019cfa 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Fix compile error
236d14f 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Remove unstable settings
9d18047 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang changed the title [WIP] *: Make tiflash compatible with the cse branch *: Make tiflash compatible with the cse branch Jan 8, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
yongman
yongman approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@yongman yongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yongman
Once this PR has been reviewed and has the lgtm label, please ask for approval from jayson-huang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2025

@yongman: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

CalvinNeo
CalvinNeo reviewed Jan 10, 2025
View reviewed changes
dbms/src/Storages/KVStore/MultiRaft/RegionPersister.cpp
{
LOG_WARNING(
log,
"Region skip restore because keyspace in blacklist, region_id={} keyspace={}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Region skip restore because keyspace in blacklist, region_id={} keyspace={}",
"Region skip restore because keyspace in blocklist, region_id={} keyspace={}",

CalvinNeo
CalvinNeo reviewed Jan 10, 2025
View reviewed changes
dbms/src/Server/Server.cpp

LOG_INFO(
log,
"Load blacklist file done, total {} keyspaces and {} regions in blacklist.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Load blacklist file done, total {} keyspaces and {} regions in blacklist.",
"Load blocklist file done, total {} keyspaces and {} regions in blacklist.",

CalvinNeo
CalvinNeo reviewed Jan 10, 2025
View reviewed changes
dbms/src/Server/Server.cpp
}
else
{
LOG_INFO(log, "blacklist file not exists or non-readble, ignore it.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LOG_INFO(log, "blacklist file not exists or non-readble, ignore it.");
LOG_INFO(log, "blocklist file not exists or non-readble, ignore it.");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo left review comments

@yongman yongman yongman approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tiflash compatible with the cse branch
3 participants
@JaySon-Huang @yongman @CalvinNeo