Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP: Fix ps_engine.raftlog unset under default raft-engine dir (#404) to release-8.1 #406

Merged
merged 3 commits into from
Feb 11, 2025
Merged

CP: Fix ps_engine.raftlog unset under default raft-engine dir (#404) to release-8.1 #406

merged 3 commits into from
Feb 11, 2025

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Dec 17, 2024 •
edited by JaySon-Huang
Loading

cherry-pick of #404

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaySon-Huang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CalvinNeo
Copy link
Member Author

/retest

@CalvinNeo
a
d79cfa3 
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Dec 17, 2024
@CalvinNeo
Copy link
Member Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaySon-Huang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

I believe there is a mistake here. The file does not change any of the config items.

@CalvinNeo CalvinNeo changed the title Cherry-pick #404 to release-8.1 CP: Fix ps_engine.raftlog unset under default raft-engine dir (#404) to release-8.1 Feb 11, 2025
@CalvinNeo CalvinNeo merged commit 3194987 into pingcap:raftstore-proxy-8.1 Feb 11, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalvinNeo @JaySon-Huang