Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 3: Sled db reopen could fail on could not acquire lock on .... on Linux #458

Open
k0Iry opened this issue Jun 4, 2023 · 1 comment
Labels
type/question Further information is requested

Comments

@k0Iry
Copy link

k0Iry commented Jun 4, 2023

Should we add some timeouts after we kill the server process?

let handle = thread::spawn(move || {
    let _ = receiver.recv(); // wait for main thread to finish
    child.kill().expect("server exited before killed");
});

When we kill the child process in which server is running, if open the sled db immediately before LOCK_UN takes effect, we probably will get this error.

Maybe adding some timeouts like 50ms or so in between can make the test cli_access_server_sled_engine more reliable.

@k0Iry k0Iry added the type/question Further information is requested label Jun 4, 2023
@k0Iry
Copy link
Author

k0Iry commented Jun 4, 2023

Also see the issue for sled here: spacejam/sled#1234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant