Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP201 Project3: write benchmark comparison between kvs and sled #383

Open
xuyifangreeneyes opened this issue Jan 8, 2021 · 3 comments
Open
Labels
type/question Further information is requested

Comments

@xuyifangreeneyes
Copy link

General Question

I am writing TP201 Project3. When doing write benchmark, I find that sled's set operation is much slower than kvs.
Screen Shot 2021-01-09 at 12 06 15 AM

I also run the Project3 code in this repo and find similar phenomenon.
Screen Shot 2021-01-08 at 11 38 32 PM
Write benchmark for sled takes so much time that it is not yet finished in the snapshot.

Is it normal that sled's set operation is much slower than kvs or I made mistakes somewhere.

Tips

Expect for asking questions on Github, you can also discuss it in the channel
#wg-talent-plan-courses. of
tidbcommunity
slack workspace.

@xuyifangreeneyes xuyifangreeneyes added the type/question Further information is requested label Jan 8, 2021
@TheLudlows
Copy link

Maybe the sled's flush is too expensive

@dreamerlzl
Copy link

Same here. In my old Intel mac laptop, it takes > 1 hour for the 100 samples, while only 3-5 secs for the referenced solution and my own solution.

@Tom910
Copy link

Tom910 commented Mar 5, 2024

The same issue. In my case helps to upgrade the version of criterion to 0.5.1 version. A new version of the library better adapt for slow sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants