Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb/mapreduce: relaxing utils/CheckFile #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tidb/mapreduce: relaxing utils/CheckFile #335

wants to merge 1 commit into from

Conversation

schneiderlin
Copy link

close #334

Side effects

  • test would be slower
  • CheckFile function's semantic is change, and should not be use in other place(maybe make it private?)

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Soline324 Soline324 requested a review from winoros April 28, 2020 01:57
@Soline324
Copy link
Contributor

Thanks for the pull, cc @winoros, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros Awaiting requested review from winoros

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component/tidb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb section2, test case false positive
4 participants
@schneiderlin @CLAassistant @Soline324 @overvenus