Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic skin #26

Open
grape6 opened this issue Jan 29, 2018 · 6 comments
Open

elastic skin #26

grape6 opened this issue Jan 29, 2018 · 6 comments

Comments

@grape6
Copy link

grape6 commented Jan 29, 2018

in elastic skin authres_status icon is shown only after pressing 'envelope' button. Maybe better
to show it always.

@pimlie
Copy link
Owner

pimlie commented Feb 2, 2018

Unfortunately I am unable to get the elastic skin working, if you could do a PR that would be great. You could add a file skins/elastic/authres_status.css which should list all css required for it to work correctly in the elastic skin.

@grape6
Copy link
Author

grape6 commented Feb 28, 2018

sorry, i'm not so familiar with elastic :)

@photoninger
Copy link
Contributor

Playhing around with roundcube-1.4.0-rc2 and elastic:

  • authres_status is working in messages_list
  • as a noob with hooks in roundcube i don't think the hook message_headers_output can change the tag <div class="header-subject"> which contains the from header in default mail view because it is not called until you click the envelope for detailed headers

@FlyveHest
Copy link

1.4.0 is now out, and elastic is the default skin going forward. If you could somehow find the time to update this great plugin, I think a lot of people would be grateful, me included :)

@SKBanan
Copy link

SKBanan commented Aug 10, 2020

This seems to be only about localization, in "authres_status.php"

public function message_summary($p){
return array('content' => preg_replace('/(<span>\s*)()(From)/', '$1' . $this->img_status . ' $3', $p['content']));

replaced with:
return array('content' => preg_replace('/(<span>\s*)()('.$this->gettext('from').')/', '$1' . $this->img_status . ' $3', $p['content']));

Now the status icon appears correctly in main "From" field, without the need to click message details

@photoninger
Copy link
Contributor

This seems to be only about localization, in "authres_status.php"

public function message_summary($p){
return array('content' => preg_replace('/(<span>\s*)()(From)/', '$1' . $this->img_status . ' $3', $p['content']));

replaced with:
return array('content' => preg_replace('/(<span>\s*)()('.$this->gettext('from').')/', '$1' . $this->img_status . ' $3', $p['content']));

Now the status icon appears correctly in main "From" field, without the need to click message details

Yes, it is about localization, I opend a pull request to change the regex: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants