Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about the ‘Ignore Empty’ option #123

Closed
Telhop opened this issue Jan 14, 2024 · 1 comment
Closed

A question about the ‘Ignore Empty’ option #123

Telhop opened this issue Jan 14, 2024 · 1 comment
Assignees
Milestone

Comments

@Telhop
Copy link

Telhop commented Jan 14, 2024

Does it operate on the final TTS message text to be sent out or the (raw) notification itself?
If it is the former, the problem this gives me is that I configure the messages to include the app name (which I would guess is quite common). This means the final text of the TTS message is never going to be empty, even if the actual notification is empty, as the final text will include the app name.
If the ‘Ignore Empty’ option works on the (raw) notification, I have evidence that it is not working.
Version: 1.3.1 [7ccf0f7]

@pilot51 pilot51 self-assigned this Jan 15, 2024
@pilot51 pilot51 added this to the v1.3.2 milestone Jan 15, 2024
@pilot51
Copy link
Owner

pilot51 commented Jan 15, 2024

It operates on the final TTS message, and you're right, that will almost never work.

It looks like 520ac19 (back in 2017) is where I broke it by switching the empty check to the TTS message without realizing the consequences and neglecting to test it. That gives me another idea for a customizable test notification.

The solution I have in mind is to check that all of the notification parts used by the TTS message are empty, excluding the app name and parts not used.

@pilot51 pilot51 modified the milestones: v1.3.2, v1.4.0 Dec 4, 2024
pilot51 added a commit that referenced this issue Dec 4, 2024
Notification is considered empty if it has no text
for the used TTS Message tags, ignoring app label.
@pilot51 pilot51 closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants