Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace numexpr? #53

Closed
cbrnr opened this issue Nov 15, 2024 · 4 comments
Closed

Replace numexpr? #53

cbrnr opened this issue Nov 15, 2024 · 4 comments

Comments

@cbrnr
Copy link

cbrnr commented Nov 15, 2024

Currently, picard cannot easily be used with Python 3.13, because numexpr (one of its dependencies) does not provide wheels. I'm not even sure if numexpr is still maintained, since I've already opened an issue but received no reply so far (plus there has been almost no activity for a long time in general).

Therefore, I was wondering if it was possible to replace numexpr e.g. with plain NumPy operations? If so, numexpr could be an optional dependency that would speed up computations if available.

Bonus question: Do you have an estimate on how much numexpr speeds up typical calculations performed in picard?

@pierreablin
Copy link
Owner

Thanks for the issue! This is fixed by #54 :)

For the bonus question, I do not remember; these were benchmarks I ran a while ago... using only numpy should be fine.

@cbrnr
Copy link
Author

cbrnr commented Nov 15, 2024

Thanks a lot for addressing this so quickly! Would it be possible to make a new release on PyPI? Again, thank you so much!

@agramfort
Copy link
Collaborator

agramfort commented Nov 17, 2024 via email

@pierreablin
Copy link
Owner

Done, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants