Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling import of (too) many markers #1

Open
elrubio opened this issue Dec 16, 2020 · 1 comment
Open

Handling import of (too) many markers #1

elrubio opened this issue Dec 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@elrubio
Copy link
Contributor

elrubio commented Dec 16, 2020

When trying to import a large number of markers, an error message tells me that belki is "Refusing to load too many (nnnn) markers".

Probably the limitation exists for performance and/or usability reasons. A look into the code reveals a hard limit of 500 markers.

In the first place, it would be convenient if the error message stated the actual limit. Something like "Refusing to load too many (nnnn) markers. Maximum is 500.". This way the user doesn't have to look up this value in the code.

But maybe the limit could be dealt with somewhat differently? I suggest to either

  1. Remove the hard limit but ask the user is it's OK to continue despite potential issues (lag, apparent freezes, etc) if more than LIMIT markers are to be loaded

or

  1. Keep the limit in place, load all markers up to LIMIT and inform the user about all three numbers: the limit, the number of markers present in the file and the number of markers that were not loaded.

or

  1. Combine both and ask the user something like

    Warning

    You are about to load 2369 markers. Loading more than 500 markers may cause serious performance issues and is not recommended."

    [Load first 500 markers] [Load all markers] [Abort]

@elrubio elrubio added the enhancement New feature or request label Dec 16, 2020
@ypnos
Copy link
Contributor

ypnos commented Dec 20, 2020

First fix in 0916b5c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants