fix(CLI): crash when target/params section is empty #STRINGS-921 #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablan
changed the title
theSoenke
reviewed
Nov 26, 2024
| if target.Params != nil { | ||
| return target.Params.Branch.Value() | ||
| } | ||
| return "" |
There was a problem hiding this comment.
Wondering whether this should be an empty string or nil when there is no branch? You could return nil when the return type is *string
There was a problem hiding this comment.
that would be quite a bigger change, but I can try
There was a problem hiding this comment.
@theSoenke sorry, I took a look, basically everywhere, branch is a string (not a pointer), so changing it would be a big effort
Things like:
openapi/clients/cli/cmd/internal/pull.go
Line 33 in d9c8271
openapi/clients/cli/cmd/internal/push.go
Line 28 in 30ae809
etc etc
There was a problem hiding this comment.
no worries! just wanted to check whether it makes sense
theSoenke
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses phrase/phrase-cli#157