Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Report Layout Mode #24

Open
patrickheeney opened this issue Sep 21, 2013 · 0 comments
Open

Form Report Layout Mode #24

patrickheeney opened this issue Sep 21, 2013 · 0 comments

Comments

@patrickheeney
Copy link

I think this needs to be more robust. I ran into some issues with existing modules where I could not customize this area enough due to it being hardcoded. Basically the choice for $form_report_layout_mode is true or false. Should look into setting this to a string or something else so we have more options on layout. The default layouts are tabs and the horizontal table report layout. I would be curious to see what we can do here. Perhaps default it $form_report_layout_mode = 'tabs'; and have the ability to specify a custom partial.

I also had to do some hackery to get the layout I wanted only on preview action. I believe _form_form.htm is used on any of the form views. I wanted it to be visible on /preview/1/ but not when used in the preview popup window.

Use Case: A client needed the tabs removed and the "tabs" would be displayed vertically down the page. I had to create a custom form_form.htm for every controller.

File in question: https://github.com/phproad/phpr-framework/blob/master/modules/db/behaviors/form_behavior/partials/_form_form.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant