-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Refresh #27
Comments
Hi, I'm Eric! I started work on this, this past weekend pulling in some colors form the main php.net site like purples/dark gray. I removed bootstrap and am now wondering if there was a specific reason for the Angular or if I could switch to some other front end JS framework. I know I'm being kind of vague about this but I'll update my fork once I get the navigation set up and open it up for feedback prior to any sort of PR. |
I only picked Angular because it was the one I tend to use the most, and we can scale it up or down depending on the need, such as having small widgets like the search pages, or full-blown mini-SPAs for different sections. If you're thinking about swapping the JS frameworks, I'd do that in a separate branch from the visual refresh, as I'm sure there will be some back-and-forth from people that I wouldn't want to stall the visual changes. |
@dragonmantank sounds good to me. This is where I'm at right now for full width basic content pages: http://codepen.io/ericnkatz/full/a3cad612b08d8755a5f26328107f57de/ I have an update in progress for homepage that includes a larger hero image and placeholder for like Still need to tweak some footer pieces and add some user interaction, but what are your thoughts so far for direction? |
So far I think it looks great! Thank you! Having a CTA on the find/become on the homepage would be a big plus, since that's the main purpose of the site. The content on the page looks and reads well to me, which is good because down the road we'll be adding more flat content, in addition to the searching. |
👍 nice, thanks @ericnkatz ! |
looks nice! 👍 |
Publishing my changes/ next revision this weekend. Sorry for the delay. :) |
Great, looking forward to it. Thank you for all the hard work! |
@ericnkatz Just wanted to follow up on this. We're hoping to go live sometime this weekend. If it still needs some polishing that's cool, we'll merge in your changes whenever you are ready. |
@dragonmantank on it, going to re-pull your changes and merge my styles/markup. |
Any update here? If the current design upgrade is aborted, I could help with that by pulling in some Google Material Design or Twitter bootstrap but can't really provide more than that... I guess that would be modern enough. |
This is what I have right now: https://github.com/ericnkatz/phpmentoring/tree/frontend |
It looks great. Feel free to send over a PR. I think there will be some merge conflicts, but we can get those ironed out. |
@ericnkatz how is this going? Can you setup a PR? Thanks! |
Make the site not look ugly.
The text was updated successfully, but these errors were encountered: