Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-15918: Assertion failure in ext/spl/spl_fixedarray.c #15947

Closed
wants to merge 1 commit into from
Closed

Fix GH-15918: Assertion failure in ext/spl/spl_fixedarray.c #15947

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

SplFixedArray should've never get supported in ArrayObject because it's overloaded, and so that breaks assumptions. This regressed in c4ecd82.

@nielsdos
Fix phpGH-15918: Assertion failure in ext/spl/spl_fixedarray.c
a9bf9a7 
SplFixedArray should've never get supported in ArrayObject because it's
overloaded, and so that breaks assumptions. This regressed in c4ecd82.
@nielsdos nielsdos linked an issue Sep 18, 2024 that may be closed by this pull request
Assertion failure in ext/spl/spl_fixedarray.c #15918
Closed
Girgias
Girgias approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nielsdos nielsdos closed this in 9774ced Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: spl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failure in ext/spl/spl_fixedarray.c
2 participants
@nielsdos @Girgias