Skip to content

Commit daa3513

Browse files
authored
ext/pgsql: pg_lo_export/pg_connection_reset returning a boolean value using RETURN_BOOL (#21150)
1 parent fdaa488 commit daa3513

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

ext/pgsql/pgsql.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3023,10 +3023,7 @@ PHP_FUNCTION(pg_lo_export)
30233023

30243024
pgsql = link->conn;
30253025

3026-
if (lo_export(pgsql, oid, ZSTR_VAL(file_out)) == -1) {
3027-
RETURN_FALSE;
3028-
}
3029-
RETURN_TRUE;
3026+
RETURN_BOOL(lo_export(pgsql, oid, ZSTR_VAL(file_out)) != -1);
30303027
}
30313028
/* }}} */
30323029

@@ -3863,10 +3860,8 @@ PHP_FUNCTION(pg_connection_reset)
38633860
pgsql = link->conn;
38643861

38653862
PQreset(pgsql);
3866-
if (PQstatus(pgsql) == CONNECTION_BAD) {
3867-
RETURN_FALSE;
3868-
}
3869-
RETURN_TRUE;
3863+
3864+
RETURN_BOOL(PQstatus(pgsql) != CONNECTION_BAD);
38703865
}
38713866
/* }}} */
38723867

0 commit comments

Comments
 (0)