Allow user to have multiple identities

Author: philtr

app/controllers/events_controller.rb

@@ -16,6 +16,8 @@ def create
 
   def show
     @event = Event.where(id: params[:id]).includes(responses: [ :user ]).first
+    redirect_to root_path if @event.nil?
+
     @response = @event.response_for(current_user).presence || Response.new rescue nil
   end
 

app/controllers/profiles_controller.rb

@@ -3,7 +3,7 @@ class ProfilesController < ApplicationController
 
   def edit
     @user = current_user
-    @user.update_column(:prompted_for_details, true)
+    @user.update_column(:profile_complete, true)
   end
 
   def update

app/controllers/sessions_controller.rb

@@ -15,10 +15,11 @@ def destroy
 
   # GET /auth/:provider/callback?param=a98xh0xeui2sc
   def create
-    @user = User.authorize(auth)
+    @identity = Identity.authorize(auth, user: current_user)
+    @user = @identity.user
     sign_in_as(@user)
 
-    unless @user.email.present? || @user.prompted_for_details?
+    unless @user.email.present? || @user.profile_complete?
       redirect_to(edit_profile_path) and return
     end
 

app/models/identity.rb

@@ -0,0 +1,98 @@
+class Identity < ActiveRecord::Base
+  belongs_to :user
+
+  before_save :assign_user
+  after_save :merge_cleanup
+
+  def assign_empty_attributes(attrs)
+    old_attributes = attributes.compact
+    new_attributes = attrs.compact
+
+    assign_attributes(new_attributes.merge(old_attributes))
+
+    self
+  end
+
+  def assign_user
+    if user_id.blank?
+      create_user(full_name: full_name, email: email)
+    end
+  end
+
+  def destroy_merged_user
+    orphaned_user.destroy if orphaned_user.present?
+  end
+
+  def destroy_duplicate_responses
+    user.responses.group_by(&:event_id).each do |event_id, responses|
+      if responses.count > 1
+        responses.first.additional_guests ||= responses.last.additional_guests
+        responses.first.comments ||= responses.last.comments
+        responses.last.destroy
+      end
+    end
+  end
+
+  def full_name
+    [ first_name, last_name ].compact.join(" ").presence
+  end
+
+  def full_name=(new_name)
+    names = new_name.to_s.split(" ")
+    self.first_name = names.shift
+    self.last_name = names.join(" ")
+  end
+
+  def merge_cleanup
+    destroy_merged_user
+    destroy_duplicate_responses
+  end
+
+  def merge_users(new_user)
+    return user unless new_user.present?
+    self.user = new_user and return if user.nil?
+
+    unless new_user.id == user_id
+      new_attributes = new_user.attributes.compact.except("id")
+      old_attributes = user.attributes.compact.except("id")
+
+      new_user.assign_attributes(new_attributes.merge(old_attributes))
+
+      user.responses.update_all(user_id: new_user.id)
+      user.created_events.update_all(created_by: new_user.id)
+
+      self.user = new_user
+    end
+  end
+
+  def orphaned_user
+    User.where(id: orphaned_user_id).first
+  end
+
+  def orphaned_user_id
+    orphaned_user_id = changes.fetch(:user_id, []).first
+    orphaned_user_id ||= previous_changes.fetch(:user_id, []).first
+  end
+
+  def self.authorize(auth, options = {})
+    identity = Identity.where(provider: auth.provider, uid: auth.uid).first_or_initialize
+
+    identity.assign_empty_attributes({
+      full_name:  auth.info.name,
+      first_name: auth.info.first_name,
+      last_name:  auth.info.last_name,
+      email:      auth.info.email,
+      avatar_url: auth.info.image,
+      token:      auth.credentials.token,
+      auth_hash:  auth.to_h,
+    })
+
+    identity.merge_users(options[:user])
+    identity.save
+
+    identity
+  end
+
+
+end
+

app/models/user.rb

@@ -2,6 +2,7 @@ class User < ActiveRecord::Base
   has_many :responses
   has_many :events, through: :responses
   has_many :created_events, class_name: "Event", foreign_key: :created_by
+  has_many :identities
 
   def attending?(event)
     events.include?(event)
@@ -23,31 +24,6 @@ def gravatar(size = 500)
     avatar_url.presence || random_avatar
   end
 
-  def assign_nil_attributes(attrs)
-    old_attributes = attributes.reject { |key, value| value.blank? }
-    new_attributes = attrs.reject { |key, value| value.blank? }
-
-    assign_attributes(new_attributes.merge(old_attributes))
-
-    self
-  end
-
-  def self.authorize(auth)
-    user = User.where(provider: auth.provider, uid: auth.uid).first_or_initialize
-
-    user.assign_nil_attributes({
-      full_name:  auth.info.name,
-      first_name: auth.info.first_name,
-      last_name:  auth.info.last_name,
-      email:      auth.info.email,
-      avatar_url: auth.info.image,
-      token:      auth.credentials.token,
-      auth_hash:  auth.to_h
-    })
-
-    user.tap(&:save)
-  end
-
   protected
 
   def random_avatar(size = 500)

bin/rails

@@ -1,8 +1,4 @@
 #!/usr/bin/env ruby
-begin
-  load File.expand_path("../spring", __FILE__)
-rescue LoadError
-end
 APP_PATH = File.expand_path('../../config/application',  __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

bin/rake

@@ -1,8 +1,4 @@
 #!/usr/bin/env ruby
-begin
-  load File.expand_path("../spring", __FILE__)
-rescue LoadError
-end
 require_relative '../config/boot'
 require 'rake'
 Rake.application.run

config/initializers/core_ext.rb

@@ -0,0 +1 @@
+require "./lib/core_ext/hash.rb"

db/migrate/20140207134315_change_users_to_identities.rb

@@ -0,0 +1,31 @@
+require './app/models/event.rb'
+require './app/models/identity.rb'
+require './app/models/response.rb'
+require './app/models/user.rb'
+
+class ChangeUsersToIdentities < ActiveRecord::Migration
+  def change
+    rename_table :users, :identities
+    add_column :identities, :user_id, :integer
+
+    create_table :users do |t|
+      t.string :first_name
+      t.string :last_name
+      t.string :email
+      t.string :avatar_url
+      t.string :timezone
+
+      t.boolean :profile_complete
+
+      t.timestamps
+    end
+
+    Identity.all.each do |identity|
+      identity.assign_user
+      identity.save
+
+      Response.where(user_id: identity.id).update_all(user_id: identity.user.id)
+      Event.where(created_by: identity.id).update_all(created_by: identity.user.id)
+    end
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20140206150758) do
+ActiveRecord::Schema.define(version: 20140207134315) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -28,6 +28,21 @@
     t.datetime "updated_at"
   end
 
+  create_table "identities", force: true do |t|
+    t.string   "provider"
+    t.string   "uid"
+    t.string   "token"
+    t.hstore   "auth_hash"
+    t.string   "first_name"
+    t.string   "last_name"
+    t.string   "email"
+    t.datetime "created_at"
+    t.datetime "updated_at"
+    t.string   "avatar_url"
+    t.boolean  "prompted_for_details", default: false
+    t.integer  "user_id"
+  end
+
   create_table "responses", force: true do |t|
     t.integer  "user_id"
     t.string   "organization"
@@ -41,17 +56,14 @@
   add_index "responses", ["event_id"], name: "index_responses_on_event_id", using: :btree
 
   create_table "users", force: true do |t|
-    t.string   "provider"
-    t.string   "uid"
-    t.string   "token"
-    t.hstore   "auth_hash"
     t.string   "first_name"
     t.string   "last_name"
     t.string   "email"
+    t.string   "avatar_url"
+    t.string   "timezone"
+    t.boolean  "profile_complete"
     t.datetime "created_at"
     t.datetime "updated_at"
-    t.string   "avatar_url"
-    t.boolean  "prompted_for_details", default: false
   end
 
 end