Add test for hsdp_iam_group_membership. Refs #311

Signed-off-by: Andy Lo-A-Foe <[email protected]>

Author: loafoe

internal/provider/provider.go

@@ -5,6 +5,8 @@ import (
 	"encoding/json"
 	"os"
 
+	"github.com/philips-software/terraform-provider-hsdp/internal/services/iam/group_membership"
+
 	"github.com/google/fhir/go/fhirversion"
 	"github.com/google/fhir/go/jsonformat"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -317,7 +319,7 @@ func Provider(build string) *schema.Provider {
 			"hsdp_connect_mdm_application":                   mdm.ResourceMDMApplication(),
 			"hsdp_connect_mdm_firmware_component_version":    mdm.ResourceConnectMDMFirmwareComponentVersion(),
 			"hsdp_connect_mdm_firmware_distribution_request": mdm.ResourceConnectMDMFirmwareDistributionRequest(),
-			"hsdp_iam_group_membership":                      iam.ResourceIAMGroupMembership(),
+			"hsdp_iam_group_membership":                      group_membership.ResourceIAMGroupMembership(),
 			"hsdp_dicom_notification":                        dicom.ResourceDICOMNotification(),
 			"hsdp_cdr_practitioner":                          practitioner.ResourceCDRPractitioner(),
 			"hsdp_iam_role_sharing_policy":                   role_sharing_policy.ResourceRoleSharingPolicy(),

internal/provider/provider_test.go

@@ -1,15 +1,17 @@
-package provider
+package provider_test
 
 import (
 	"testing"
+
+	"github.com/philips-software/terraform-provider-hsdp/internal/provider"
 )
 
 func TestProvider(t *testing.T) {
-	if err := Provider("v0.0.0").InternalValidate(); err != nil {
+	if err := provider.Provider("v0.0.0").InternalValidate(); err != nil {
 		t.Fatalf("err: %s", err)
 	}
 }
 
 func TestProvider_impl(t *testing.T) {
-	var _ = Provider("v0.0.0")
+	var _ = provider.Provider("v0.0.0")
 }

internal/services/iam/resource_iam_group_membership.go internal/services/iam/group_membership/resource_iam_group_membership.go

@@ -1,4 +1,4 @@
-package iam
+package group_membership
 
 import (
 	"context"
@@ -7,6 +7,7 @@ import (
 
 	"github.com/cenkalti/backoff/v4"
 	"github.com/google/uuid"
+
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/philips-software/go-hsdp-api/iam"

internal/services/iam/group_membership/resource_iam_group_membership_test.go

@@ -0,0 +1,69 @@
+package group_membership_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/philips-software/terraform-provider-hsdp/internal/acc"
+)
+
+func TestAccResourceIAMGroupMembership_basic(t *testing.T) {
+	t.Parallel()
+
+	resourceName := "hsdp_iam_user.test"
+	parentOrgID := acc.AccIAMOrgGUID()
+	randomName := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			acc.PreCheck(t)
+		},
+		ProviderFactories: acc.ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				ResourceName: resourceName,
+				Config:       testAccResourceIAMUser(parentOrgID, randomName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(resourceName, "organization_id", parentOrgID),
+				),
+			},
+		},
+	})
+}
+
+func testAccResourceIAMUser(parentOrgID, name string) string {
+	return fmt.Sprintf(`
+resource "hsdp_iam_user" "test" {
+  login           = "%s"
+  email           = "acceptance+%[email protected]"
+  first_name      = "ACC"
+  last_name       = "Developer"
+  password        = "DoNot@123"
+  organization_id = "%s"
+}
+
+resource "hsdp_iam_group" "test" {
+  name = "test-%s"
+  managing_organization = "%s"
+  description = "Acceptance Test for User"
+  users = []
+  roles = []
+
+  drift_detection = false
+}
+
+resource "hsdp_iam_group_membership" "test" {
+  iam_group_id = hsdp_iam_group.test.id
+  users = [hsdp_iam_user.test.id]
+}
+`,
+		// IAM_USER
+		name, name, parentOrgID,
+		// IAM_GROUP
+		name,
+		parentOrgID,
+		// IAM_GROUP_MEMBERSHIP
+	)
+}