Issue in implementation according to CLEAN Arch

[Kaaveh]

In data class Note in the domain, you mark it as @Entity with Room annotation. I think you involve your domain layer with data layer implementation and if you change your DB in future, your domain layer take effect.

[ootoladepaul]

please when will this issue be close?

[olukayodepaul]

@Kaaveh is very correct.

Suggestion

1. @entity should be in the data layer
2. while the model should be in the domain layer
3. Transform @entity from the data layer to the model in the domain layer.

_fun Notes.toNotes (): Note{
    return Note(
        title, content, timestamp, color, id
    )
}_

The Advantage of this is that, when for example we change the cache mechanism (database), the changes will only take place in the data layer not changing the model in the domain layer

[Patrulescu-Ronald-Sandrino]

@olukayodepaul, could you create a PR w/ the changes?

[olukayodepaul]

@Patrulescu-Ronald-Sandrino here is the link to my repo where you can see the separation https://github.com/olukayodepaul/FaceOff