Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: outline-dropdown has hard-coded colors #349

Open
mike-potter opened this issue Sep 15, 2022 · 1 comment
Open

[Bug]: outline-dropdown has hard-coded colors #349

mike-potter opened this issue Sep 15, 2022 · 1 comment
Labels
Requires Triage A ticket that requires verification before being worked. Type: Bug

Comments

@mike-potter
Copy link
Member

mike-potter commented Sep 15, 2022

Describe the bug

The outline-dropdown component doesn't define its own color cssvars and instead is using gray and black colors:

  border-color: var(--outline-gray-400);
  background-color: var(--outline-gray-200);
  color: var(--outline-black);

Expected behavior
Sites using outline-dropdown should be able to set their own cssvars for these colors without overriding the gray and black base colors.

Ran into this when using outline-dropdown for the main menu items.

Actually, there might need to be variants to handle different color schemes. I could see outline-dropdown being used for a simple Select list of items, which is different than using it for the menu dropdown elements. Probably can't have a single color variable for both situations. So similar to buttons, might need to have variants like menu or select dropdowns?

@mike-potter mike-potter added Type: Bug Requires Triage A ticket that requires verification before being worked. labels Sep 15, 2022
@mike-potter
Copy link
Member Author

Related to this, the outline-dropdown has a hardcoded min-width of 350px that makes it difficult to use with menus that might have wider menu items. See the IDB for an older outline-dropdown that doesn't have these issues. Probably need some sort of width property or variant as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Triage A ticket that requires verification before being worked. Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant