Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Array>>#levenshteinDistanceTo: #20

Open
jordanmontt opened this issue Aug 5, 2021 · 3 comments
Open

Add test for Array>>#levenshteinDistanceTo: #20

jordanmontt opened this issue Aug 5, 2021 · 3 comments

Comments

@jordanmontt
Copy link
Member

The method Array>>#levenshteinDistanceTo: is never called by any test. Only the ones that are called are the levenshtein methods defined in String class.

@jordanmontt
Copy link
Member Author

Hi @hernanmd 😄
Does the levenshtein distance can be applied to Arrays with numbers? Like #(1 2 3) distanceTo: #(3 4 5) using: AILevenshteinDistance
Because from what I have been reading this distance algorithm is only applied to Strings.

@hernanmd
Copy link
Member

hernanmd commented May 6, 2022

Hi @jordanmontt.

IMO there is no reason why couldn't be applied to Arrays with numbers. Here are some links as examples in other languages:

@hernanmd hernanmd reopened this May 6, 2022
@jordanmontt
Copy link
Member Author

Thanks for your answer Hernan, we will fix the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants