Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice of symbol for the Ammeter? #110

Open
SirClickALot opened this issue Oct 6, 2024 · 4 comments
Open

Choice of symbol for the Ammeter? #110

SirClickALot opened this issue Oct 6, 2024 · 4 comments

Comments

@SirClickALot
Copy link

I am hoping to use circuitjs1 in helping to teach very basic secondary school level (aged 11-16) electronics in Computer Science.

Pretty early on I have discovered that the symbol for the ammeter is not what I expected, is at odds with the normal convention and that's going to confuse young learners needlessly I think.

I'm curious as the default choice for the Ammeter symbol because (in my setup at least) it looks far too close to Diode to me and that's really going to cause confusion.

Here is a mock-up of what I (and students) would expect an ammeter to look like...

image

Thank you

@pfalstad
Copy link
Owner

pfalstad commented Oct 6, 2024

That code was contributed by someone. I like your choice of symbol better.

@SirClickALot
Copy link
Author

OK, great, thanks Paul.
Do you know where these graphics exist within the codebase - I want to do some experiments to see if I can override the Ammeter one but I am unsure where to find and in what format. My instinct was that they might be SVG files but I cannot see any such collection.

@pfalstad
Copy link
Owner

pfalstad commented Oct 7, 2024

They're all done procedurally, in code. I don't know if SVG existed when I started working on this, or I didn't know about it at least. Also, I don't know if SVG would work because the various parts need to be draw in different colors depending on the voltage, and we need to know the path of the current so we can animate it.

This one is done in the draw() method of AmmeterElm.java

@SirClickALot
Copy link
Author

SirClickALot commented Oct 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants