Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCSS implementation #20

Open
7 tasks
dmnsgn opened this issue May 31, 2024 · 0 comments
Open
7 tasks

PCSS implementation #20

dmnsgn opened this issue May 31, 2024 · 0 comments

Comments

@dmnsgn
Copy link
Member

dmnsgn commented May 31, 2024

  • number of samples (blocker 25 and filter 64) seems to yield satisfying results
  • is it correct to only do texture2DCompare in PCSSPCFFilter (not sure doing lerp or any kernel pcf helping since we’re already “sampling around” within the golden vogel disk; performance is dreadful if we should to do that and we'd need to use less filter sample than 64).
  • PCSS texture cube for point lights doesn’t have biased z
  • sampling pattern very visible in specular reflection when light intensity high. Higher pixel ratio and shadow map size can help reduce a bit, at a perf cost.

Also needing pex-renderer tweaks:

  • it is still dependent on shadowmap size
  • sportlight penumbra should be relative to light space z (.bulbRadiusLs / zLight;)
  • if bulbRadius is too big, we see the edge of the light depth map because we’re sampling outside its bbox (it is normal, unless we find a heuristic to make lightbox view size dependent on that bulbRadius?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant