-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan to port to angular 17 ? #11
Comments
Hi @zucatti . Do you want to port it to angular 17? I may contribute. I am not advanced in Angular but willing to use it too. So if the owner agrees, maybe we can do it? |
This is definitely a good idea, I wonder if the owner are interested? |
Hi @cgglyle any ideas on how to get hold of the owner or we can go it ourselves? |
Hi @ENate The owner doesn't look like he's updated any code in two years, it looks like the whole project is no longer being maintained, and I'm just a front-end beginner who was hoping to learn angular through the whole project, but it's a headache with version dependency issues and obsolescence. |
@ENate And the commit log for this project has no valid information. E.g. update, wip, sadasdsa, fsfd... |
Hi Guys, You can freely port this project to angular 17 if you want.... and you can open a PR for it, and I will review it and I can make you a contributor of this project. "It looks like the owner is not interested in writing detailed logs." |
Hi @petter-ka thanks for the template and getting back. So are we all ready to port this to angular 17? |
Hi @petter-ka I actually took a look at the project and also trying to update it. It seems there are quite some changes especially with the Carbon Design system. My question is: Can you comment on the |
Hi @MHipo , The tailwind.css is the original tailwind style file, because back then I did not make it to work with the standard way. So I just copy pasted it. Besides, you are right, the Carbon System is changed a lot. Thank you |
hI @petter-ka I have a good update of most of the packages but stuck somewhere with issues relating to styles. Can you check and make comments? I can open a PR with what I have done so far. |
Hey @ENate , I was about to start upgrading this Project to Angular latest. Thank you! |
Yes @petter-ka. Done! |
Hi @ENate , |
Hi @petter-ka . Will do. But know that parts of the update with styling is not working. I do not know whether this will affect the vercel deployment. But if it is just the for the build, then I guess then fine. |
Hi @ENate , |
Hi @petter-ka . Sure I can. But I have never used vercel until now :). If I register and deploy to vercel, will it be faster for you to check? And if it deploys to vercel, can you see the issues from there? The main issue I encountered was with the themes section (folder). I was unable to fully update the whole themes. I noticed that there were a number of changes to the latest Carbon theme versions. In my opinion, it seems the issues were mainly how they were imported to the app. I also tried to link in tailwindCSS as discussed in the doc and there were still some issues - but I finally noticed that the issue may be due to the IDE I used. I presume we may not need to directly copy the tailwind.css file but create a config file and link up the CDN. I do not know if these issues will show up if I deployed first on Vercel. What do you think? I can provide further details about the issues. Great job you did with the original template. We can finish the remaining updates if these issues are clarified in my opinion. |
Hi @petter-ka It may be best to update to standalone though. If you confirm this, I may consider too. |
No description provided.
The text was updated successfully, but these errors were encountered: