No output when calling callMain with args

[williamfzc]

This project is really cool. Thanks for all your work!

I have followed some related issues (#80) to capture the output, which working fine in some simple cases.

But it seems not work if I sending some args together.

// OK
lg.callMain(["log"])
// NO OUTPUT
lg.callMain(["log", "-p"])

Full snippet:

const lg = require('./node_modules/wasm-git/lg2.js');
let stdout;


lg["print"] = function (text) {
    console.log(text);
}

lg["printErr"] = function (text) {
    console.error(text);
}

lg.onRuntimeInitialized = () => {
    const FS = lg.FS;
    const NODEFS = FS.filesystems.NODEFS;

    FS.mkdir('/working');
    FS.mount(NODEFS, {root: '..'}, '/working');
    FS.chdir('/working');

    const gitConfigContent = '[user]\n' +
        'name = Test User\n' +
        'email = [email protected]\n' +
        '[safe]\ndirectory = *\n';

    FS.writeFile('/home/web_user/.gitconfig', gitConfigContent, (err) => {
        if (err) throw err;
        console.log('File has been saved!');
    });

    console.log(FS.readdir('.'));

    // OK
    lg.callMain(["log"])
    // NO OUTPUT
    lg.callMain(["log", "-p"])
};

[petersalomonsen]

Sorry for the late reply, but thanks for nice feedback!

The log command comes directly from here: https://github.com/libgit2/libgit2/blob/main/examples/log.c#L473

Can you try compiling the libgit2 examples directly ( as native, not as Wasm ) and see if the -p switch works there? Either it's missing in the example from libgit2, or it might not work when used in Wasm ( but I doubt that ). For everything that I've been missing from the libgit2 examples, I've added to the libgit2patchedfiles/examples folder, but as you can see I haven't patched the log command. It comes directly out of libgit2.

[williamfzc]

Thanks for your reply!
Unfortunately I only have my laptop nearby which has no any compile env. :(

But I do some search in libgit2 and find this:

libgit2/libgit2#4209

which may can indicate the original example working fine.

[petersalomonsen]

That links also says it takes longer time with libgit2 than with normal git. Does it make any difference with a small vs a larger repository?