-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 modules support #46
base: master
Are you sure you want to change the base?
Conversation
Please accept this pull request so we don't have to use forks.. @petehunt Are you still using the jsx-loader at Instagram and Facebook? If not, what are you using instead? |
I found out that babel-loader works fine. |
@prayerslayer Sure but babel-loader is slow and shouldn't be used on too many files (just quoting the docs). Are you working on a big codebase with it? |
No, just starting. Would you mind posting a link to said docs? -----Original Message-----
|
It is actually in the readme file: https://github.com/babel/babel-loader#babel-loader-is-slow |
Sorry I have to nitpick here, but it doesn't say that it's slow and you shouldn't use it on a large codebase. It says if you're experiencing a slow babel-loader, then make sure you're not doing unnecessary transformation. Which sounds reasonable. But I don't want to imply that you are wrong! Have you tried babel on your code? What scale of "slow" are we talking about? Edit: On a second read I get that the babel-loader docs are not really clear on this part. One could understand it both ways. But since it's listed under "troubleshooting" I didn't get the impression that "babel is slow" is meant as a warning. :) |
You're completely right. However when we tested both tools, jsx was faster than Babel. |
Would it be possible to get this patch merged? Thanks. |
👍 to just using the babel-loader. It works great for me. |
Fixes #45.