Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 modules support #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ES6 modules support #46

wants to merge 2 commits into from

Conversation

prayerslayer
Copy link

Fixes #45.

@prayerslayer prayerslayer changed the title Issue 45 es6 modules ES6 modules support Mar 13, 2015
@theasta
Copy link

theasta commented Mar 17, 2015

Please accept this pull request so we don't have to use forks.. @petehunt Are you still using the jsx-loader at Instagram and Facebook? If not, what are you using instead?

@prayerslayer
Copy link
Author

I found out that babel-loader works fine.

@theasta
Copy link

theasta commented Mar 17, 2015

@prayerslayer Sure but babel-loader is slow and shouldn't be used on too many files (just quoting the docs). Are you working on a big codebase with it?

@prayerslayer
Copy link
Author

No, just starting. Would you mind posting a link to said docs? 

-----Original Message-----
From: Alexandrine Boissière [email protected]
Reply: petehunt/jsx-loader [email protected]>
Date: 17 Mar 2015 at 21:54:29
To: petehunt/jsx-loader [email protected]>
Cc: Nikolaus Piccolotto [email protected]>
Subject:  Re: [jsx-loader] ES6 modules support (#46)

@prayerslayer Sure but babel-loader is slow and shouldn't be used on too many files (just
quoting the docs). Are you working on a big codebase with it?


Reply to this email directly or view it on GitHub:
#46 (comment)

@theasta
Copy link

theasta commented Mar 17, 2015

It is actually in the readme file: https://github.com/babel/babel-loader#babel-loader-is-slow

@prayerslayer
Copy link
Author

Sorry I have to nitpick here, but it doesn't say that it's slow and you shouldn't use it on a large codebase. It says if you're experiencing a slow babel-loader, then make sure you're not doing unnecessary transformation. Which sounds reasonable.

But I don't want to imply that you are wrong! Have you tried babel on your code? What scale of "slow" are we talking about?

Edit: On a second read I get that the babel-loader docs are not really clear on this part. One could understand it both ways. But since it's listed under "troubleshooting" I didn't get the impression that "babel is slow" is meant as a warning. :)

@theasta
Copy link

theasta commented Mar 18, 2015

You're completely right. However when we tested both tools, jsx was faster than Babel.

@dhbaird
Copy link

dhbaird commented Jul 1, 2015

Would it be possible to get this patch merged? Thanks.

@micahlmartin
Copy link

👍 to just using the babel-loader. It works great for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES6 module support
4 participants