Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent signal handler for Unix signals #25

Open
pmk21 opened this issue Aug 23, 2020 · 2 comments
Open

Independent signal handler for Unix signals #25

pmk21 opened this issue Aug 23, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pmk21
Copy link
Collaborator

pmk21 commented Aug 23, 2020

Requested Feature
Add a separate signal handler, for better handling of Unix signals.

Suggested Solution
The signal-hook crate could be used to create signal handlers.

Additional context

Key::Char('q') | Key::Ctrl('c') => {

For example here Ctrl + C is a SIGINT signal which could be handled by a signal handler instead of handling it as a keyboard event.

This probably needs further discussion before any action is taken. Feel free to comment below

@pmk21 pmk21 added enhancement New feature or request help wanted Extra attention is needed labels Aug 23, 2020
@AkshathaLaxmi
Copy link
Contributor

Hi! A problem I see with the solution that is suggested is that rshark might not work in a Windows environment due to signal-hook not having support for signals in Windows. Maybe an alternative would be to use the crate ctrlc?

@pmk21
Copy link
Collaborator Author

pmk21 commented Mar 22, 2021

Right now I don't think even rshark works for Windows. But ctrlc seems a better choice if we later decide to support Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants