remove doubles because they are stupid

Author: ryanong

README.md

@@ -115,25 +115,6 @@ To stub methods during instantiation just add arguments.
 book = Spy.mock(book, :first_name, author: "Neil Gaiman")
 ```
 
-### Test Doubles
-
-You really shouldn't use these and use Mocks as much as possible. If you really
-want to use it you must require `spy/double`.
-A test double is an object that stands in for a real object.
-
-```ruby
-require 'spy/double'
-Spy.double("book")
-```
-
-Spy will let you stub on any method even if it doesn't exist if the object is a double.
-
-Spy comes with a shortcut to define an object with methods.
-
-```ruby
-Spy.double("book", title: "Grapes of Wrath", author: "John Steinbeck")
-```
-
 ### Arbitrary Handling
 
 If you need to have a custom method based in the method inputs just send a block to `#and_return`

lib/spy.rb

@@ -1,5 +1,6 @@
 require "spy/core_ext/marshal"
 require "spy/agency"
+require "spy/base"
 require "spy/call_log"
 require "spy/constant"
 require "spy/exceptions"

lib/spy/agency.rb

@@ -22,8 +22,7 @@ def find(id)
     # @return [spy]
     def recruit(spy)
       raise AlreadyStubbedError if @spies[spy.object_id]
-      case spy
-      when Subroutine,  Constant, Double
+      if spy.is_a? Base
         @spies[spy.object_id] = spy
       else
         raise ArgumentError, "#{spy}, was not a spy"
@@ -35,8 +34,7 @@ def recruit(spy)
     # @return [spy]
     def retire(spy)
       raise NoSpyError unless @spies[spy.object_id]
-      case spy
-      when Subroutine,  Constant, Double
+      if spy.is_a? Base
         @spies.delete(spy.object_id)
       else
         raise ArgumentError, "#{spy}, was not a spy"
@@ -47,8 +45,7 @@ def retire(spy)
     # @param spy [Subroutine, Constant, Double]
     # @return [Boolean]
     def active?(spy)
-      case spy
-      when Subroutine,  Constant, Double
+      if spy.is_a? Base
         @spies.has_key?(spy.object_id)
       else
         raise ArgumentError, "#{spy}, was not a spy"

lib/spy/base.rb

@@ -0,0 +1,4 @@
+module Spy
+  module Base
+  end
+end

lib/spy/constant.rb

@@ -1,6 +1,6 @@
 module Spy
   class Constant
-
+    include Base
     # @!attribute [r] base_module
     #   @return [Module] the module that is being watched
     #

lib/spy/double.rb

@@ -4,6 +4,7 @@ module Spy
   # If you attempt to stub a method on the mock that doesn't exist on the
   # original class it will raise an error.
   module Mock
+    include Base
     CLASSES_NOT_TO_OVERRIDE = [Enumerable, Numeric, Comparable, Class, Module, Object]
     METHODS_NOT_TO_OVERRIDE = [:initialize, :method]
 

lib/spy/mock.rb

@@ -1,5 +1,6 @@
 module Spy
   class Subroutine
+    include Base
     # @!attribute [r] base_object
     #   @return [Object] the object that is being watched
     #
@@ -45,7 +46,6 @@ def hook(opts = {})
       @hook_opts = opts
       @original_method_visibility = method_visibility_of(method_name)
       hook_opts[:visibility] ||= original_method_visibility
-      hook_opts[:force] ||= base_object.is_a?(Double)
 
       if original_method_visibility || !hook_opts[:force]
         @original_method = current_method

lib/spy/subroutine.rb

@@ -16,14 +16,9 @@ class TestSubClass < TestClass
   P = :p
 end
 
-require "rspec/mocks/mutate_const"
-
 module Spy
   describe "Constant Mutating" do
 
-    require "rspec/mocks/mutate_const"
-    include RSpec::Mocks::RecursiveConstMethods
-
     def reset_rspec_mocks
       Spy.teardown
     end
@@ -360,9 +355,6 @@ def change_const_value_to(value)
   end
 
   describe Constant do
-    require "rspec/mocks/mutate_const"
-    include RSpec::Mocks::RecursiveConstMethods
-
     def reset_rspec_mocks
       Spy.teardown
     end