-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-i18next for String Localization #51
base: main
Are you sure you want to change the base?
Conversation
Hey, looks like a great start. Soe comments:
TIA |
@gemanor yes, this branch is up to date with main branch please review this PR |
Hey @techmannih, your PR is missing many strings in the |
@gemanor please review now |
@techmannih seems like the lint/prettier is still failing (see the CI tests..) |
Hey @techmannih , all the tests are passing now on main |
@gemanor I am able to see any command in components / lib. can you help me to show |
@gemanor now all test pass, please check |
Hey @techmannih, there are many strings in the |
Tests are good now indeed :) |
@gemanor these are not command string there are only error and text string, I think we are fixing command string, please confirm, if I am correct
|
It should be on all strings. Actually, everything in the components is something that renders as part of the commands. The command folder is only the high-level component of the commands |
close #39
@quest-bot loot #39
@gemanor I want to know if I am going in the right direction, and what you think about the implementation. Your feedback and advice give me a lot of confidence. After your confirmation, I will proceed with implementing the other commands