-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support .env config from other folders #201
Comments
Hey @orweis can you explain me the issue and the changes needed, I don't know the tech stack but definitely want to give it a try if possible |
Hi @money8203 , Confi is OPAL's configuration framework (homebrewed) - https://github.com/permitio/opal/blob/master/packages/opal-common/opal_common/confi/confi.py It loads config values for OPAL from 3 potential sources - ENV-var, cmd line parameters, and config files (.env and .ini). We'd like to have the default location it searches for config files in as the current working dir, and maybe also an ENV_VAR that controls that path |
Some suggestions I found on how we can fix the bug:
Here's a sample of updated code for the above feedback:
|
Hi I think you got the right direction here, but note the trick is with "_load_config_file" as this bit of the code is within decouple, and not part of OPAL's direct code |
Hi @orweis |
Hi @Rajat0002 :) |
Hey @orweis, is this issue still happening? If so, could I give it a try? Also, I've read the thread here but I might need more help on the matter. |
Hi sorry for the late reply. while not an urgent issue this is still open. |
@orweis no worries, I'll see what I can do here and might ask for help if needed! It's my first contribution to the project so I'd love to get some grasp of the structure through this task! |
Describe the bug
No easy way of setting .env
OPAL uses decouple to parse configuration from
.env
and.ini
files (As part of Confi)BY default it looks for them in the folder of the importing module - we should add support for a configurable folder or at least the current-directory
The text was updated successfully, but these errors were encountered: