Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we allow duplicate conditions? #302

Open
syldb opened this issue Feb 21, 2018 · 1 comment
Open

Should we allow duplicate conditions? #302

syldb opened this issue Feb 21, 2018 · 1 comment

Comments

@syldb
Copy link

syldb commented Feb 21, 2018

Before PR #301, a form with two identical conditions was considered invalid.

Since we've added the support for multiple conditions targeting a common field, such a form is now valid.

This behaviour is tested in test_end_point.py with the test called test_create_form_conditions_invalid_dup. We should decide if a form with two identical conditions should be considered valid or invalid.

@BlueCutOfficial
Copy link

This question should be addressed to the product, but I don't see any reason to set the form invalid. If you need to check the condition already exists well... the check is done. From this point, if the conditions are identical, can't you just ignore the second one?

Anyway, the final decision about this is also a frontend concern, because we can't let the user save and close the conditions modal if its content is invalid. Just like the case #301 we need to make sure that the backend behaviour matches with the current front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants