Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore: create threshold for price mover #347

Open
erwanor opened this issue Feb 4, 2025 · 3 comments
Open

explore: create threshold for price mover #347

erwanor opened this issue Feb 4, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@erwanor
Copy link
Member

erwanor commented Feb 4, 2025

Image

There's 1 USDT in the shielded pool, so this is less impressive than it look. We should add a filter to only retrieve assets with sufficient volume (denominated in USDC).

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Feb 4, 2025
@erwanor erwanor moved this from 🗄️ Backlog to 📝 Todo in Penumbra web Feb 4, 2025
@cronokirby
Copy link
Contributor

Note, there should already be a filtering mechanism (based on usdc liquidity) we should see what the result of turning that knob is

@erwanor
Copy link
Member Author

erwanor commented Feb 5, 2025

Note, there should already be a filtering mechanism (based on usdc liquidity) we should see what the result of turning that knob is

What is that mechanism? the liquidity columns? what's the difference between them? are they denominated in USDC or the quote token for that pair

@TalDerei TalDerei added the bug Something isn't working label Feb 5, 2025
@cronokirby
Copy link
Contributor

cronokirby commented Feb 5, 2025

penumbra-zone/penumbra#4936 we should merge this, which allows configuring the knob (setting the minimum liquidity on the command line, instead of having to edit the code) and then just run pindexer (no need to wipe the events database, you can change the liquidity knob and it just affects the next aggregate summary you produce) with some eyeballed value, e.g. 100 USDC or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📝 Todo
Development

No branches or pull requests

3 participants