Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use c8 for code coverage #46

Open
GMartigny opened this issue Sep 21, 2018 · 4 comments
Open

Use c8 for code coverage #46

GMartigny opened this issue Sep 21, 2018 · 4 comments
Labels
🔧 technical Change on technical aspect of the project

Comments

@GMartigny
Copy link
Member

Since node 10.10.0, code coverage is natively supported. The c8 package use this new feature and report a ~300% performance improvement.
Once this feature has live a little and node is more widely used, we should use it instead of nyc.

@GMartigny GMartigny added the 🔧 technical Change on technical aspect of the project label Sep 21, 2018
@GMartigny
Copy link
Member Author

Need bcoe/c8#34 issue to be resolved.

@bcoe
Copy link

bcoe commented May 2, 2019

@GMartigny there is now support for source-maps in c8, might be worth digging into this again.

@GMartigny
Copy link
Member Author

@bcoe Thanks for the heads up. I tried it, but I still have trouble with the coverage value. I've set sourceMap to esm, run c8 ava (which itself require esm) and the result is off.

image

I'll try to create a minimal reproduction repo and keep you updated.

@GMartigny
Copy link
Member Author

Hi again @bcoe,
You can try a minimal reproduction of my setup for yourself. I may be doing something wrong, but for now this report a 100% coverage when it should not be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 technical Change on technical aspect of the project
Projects
None yet
Development

No branches or pull requests

2 participants