Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add some BUILD.bazel files to support bazel build? #269

Open
HiaWinter opened this issue May 12, 2023 · 7 comments · Fixed by #271
Open

Could you add some BUILD.bazel files to support bazel build? #269

HiaWinter opened this issue May 12, 2023 · 7 comments · Fixed by #271

Comments

@HiaWinter
Copy link

My project using bazel to build and I want to import your project, if you think it's ok to add some BUILD.bazel files in your project, I can raise a PR to support it, thanks.

@LecrisUT
Copy link
Collaborator

LecrisUT commented May 16, 2023

As long as the main build is going through cmake it should be fine. Can discuss more about the design in the PR since it is faster to weed out the details with an example.

@pboettch
Copy link
Owner

pboettch commented May 16, 2023

Oh, I think we should just change it back for people using the library without CMake after building. There are some I guess. Could you take care of it, @LecrisUT - as you are the who broke it :-P .

@LecrisUT
Copy link
Collaborator

Sure, I'll make a hotfix in a minute. Let's open an issue to plan some renamings. Target names will become unmanagable otherwise.

@LecrisUT LecrisUT mentioned this issue May 16, 2023
@LecrisUT
Copy link
Collaborator

@pboettch Sorrry, we got the wrong issue here. This is the bazel issue not the soname one

@pboettch pboettch reopened this May 16, 2023
@pboettch
Copy link
Owner

Not we. It's only me. Doing 5 things at the same time....

@LecrisUT
Copy link
Collaborator

Also to blame because I marked it with Fixes in the PR 😁

@pboettch
Copy link
Owner

HiaWinter, are you able to suggest a PR for integrating Bazel-support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants