Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Images losing EXIF data #21

Closed
staegi opened this issue May 20, 2020 · 1 comment
Closed

Images losing EXIF data #21

staegi opened this issue May 20, 2020 · 1 comment

Comments

@staegi
Copy link

staegi commented May 20, 2020

To be able to use such libraries like https://www.npmjs.com/package/react-exif-orientation-img to rotate images correctly in the frontend, this add-on should pass through the EXIF data of the images.

@pauloamgomes
Copy link
Owner

Hi @staegi , thanks for you comment. I understand the issue, but I'm using core cockpit functions to save the images:

$thumb = $this->app->module('cockpit')->thumbnail($options);

Think you should open an issue on Cockpit project, it uses the claviska\SimpleImage library to handle the resize of images, and also seem to be discussed on claviska/SimpleImage#157

Tbh, I would prefer to have a different image manipulation library, but didn't had the time to change the image styles implementation.

@staegi staegi closed this as completed May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants