Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git open commit #125

Open
monkindey opened this issue Jun 23, 2018 · 8 comments
Open

git open commit #125

monkindey opened this issue Jun 23, 2018 · 8 comments

Comments

@monkindey
Copy link

monkindey commented Jun 23, 2018

How about git open --commit xxxx?

@ffes
Copy link
Collaborator

ffes commented Jun 24, 2018

Good idea!

But somebody has to do it 😉

@derimagia
Copy link
Collaborator

derimagia commented Jun 24, 2018

It should be able to auto-detect (see if the commit exists) maybe? Instead of having a flag for it

@iliaskarim
Copy link

iliaskarim commented Jul 10, 2018

Feature request: git open opens the latest pull request opened for the current branch.

@paulirish
Copy link
Owner

@ILI4S it was attempted here #53 but currently resolving the pull request URL is nontrivial, so we prefer one of two options:

  1. load the branch page (which has a link to the PR in the ui):
    image

  2. use issue branch naming and use the --issue flag, as documented in the readme.

@mlncn
Copy link

mlncn commented Sep 20, 2019

Pull request #144 added this option:

    -c, --commit          open current commit

As documented it is only for the current commit; trying to open a commit with an explicit value results in an error:

git-open --commit=8bb53b52560ea
error: option `commit' takes no value

And git-open -c 8bb53b52560ea results in a nonsense URL like https://8bb53b52560ea/8bb53b52560ea/commit/56ddf13245a99490b5c079cdc4ab66b77809dae4

We may have to change the way the current commit works, or even with the flag do what derimagia said and check values so that existing commits aren't misinterpreted.

@wingleung
Copy link

PR #155 allows me to pass a specific commit hash

@skypesky
Copy link

Does anyone still need this feature?

@skypesky
Copy link

skypesky commented Jan 27, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants