Replace all instances of HeaderClientChannel::newChannel with (facebook#418)

Summary:

This is for the purpose of testing a hypothesis that some internal difference
between HeaderClientChannel and RocketClientChannel is causing high
latency/hangs during thrift requests to FBOSS services in OSS.

Differential Revision: D73672539

Author: Paul Cruz

fboss/agent/test/MultiNodeOpenrTests.cpp

@@ -42,7 +42,7 @@ std::unique_ptr<Client> createPlaintextClient(const int port) {
   auto sock = folly::AsyncSocket::newSocket(eb, addr, kConnTimeout);
   sock->setSendTimeout(kSendTimeout);
   auto channel =
-      apache::thrift::HeaderClientChannel::newChannel(std::move(sock));
+      apache::thrift::RocketClientChannel::newChannel(std::move(sock));
   channel->setTimeout(kRecvTimeout);
   return std::make_unique<Client>(std::move(channel));
 }

fboss/agent/test/MultiNodeTest.cpp

@@ -127,7 +127,7 @@ std::unique_ptr<FbossCtrlAsyncClient> MultiNodeTest::getRemoteThriftClient()
       FLAGS_multiNodeTestRemoteSwitchName);
   folly::SocketAddress agent(remoteSwitchIp, 5909);
   auto socket = folly::AsyncSocket::newSocket(eb, agent);
-  auto chan = HeaderClientChannel::newChannel(std::move(socket));
+  auto chan = RocketClientChannel::newChannel(std::move(socket));
   return std::make_unique<FbossCtrlAsyncClient>(std::move(chan));
 }
 

fboss/cli/fboss2/utils/CmdClientUtilsCommon.h

@@ -43,7 +43,7 @@ std::unique_ptr<Client> createPlaintextClient(
   auto sock = folly::AsyncSocket::newSocket(eb, addr, kConnTimeout);
   sock->setSendTimeout(kSendTimeout);
   auto channel =
-      apache::thrift::HeaderClientChannel::newChannel(std::move(sock));
+      apache::thrift::RocketClientChannel::newChannel(std::move(sock));
   channel->setTimeout(kRecvTimeout);
   return std::make_unique<Client>(std::move(channel));
 }

fboss/qsfp_service/lib/oss/QsfpClient.cpp

@@ -19,7 +19,7 @@ QsfpClient::createClient(folly::EventBase* eb) {
     auto socket = folly::AsyncSocket::newSocket(eb, addr, kQsfpConnTimeoutMs);
     socket->setSendTimeout(kQsfpSendTimeoutMs);
     auto channel =
-        apache::thrift::HeaderClientChannel::newChannel(std::move(socket));
+        apache::thrift::RocketClientChannel::newChannel(std::move(socket));
     return std::make_unique<apache::thrift::Client<QsfpService>>(
         std::move(channel));
   };

fboss/qsfp_service/lib/test/QsfpCacheExerciser.cpp

@@ -32,7 +32,7 @@ std::unique_ptr<apache::thrift::Client<FbossCtrl>> fbossAgentClient() {
   folly::EventBase* eb = folly::EventBaseManager::get()->getEventBase();
   folly::SocketAddress agent(FLAGS_qsfp_service_host, 5909);
   auto socket = folly::AsyncSocket::newSocket(eb, agent);
-  auto chan = HeaderClientChannel::newChannel(std::move(socket));
+  auto chan = RocketClientChannel::newChannel(std::move(socket));
   return std::make_unique<apache::thrift::Client<FbossCtrl>>(std::move(chan));
 }
 

fboss/util/ThriftStateUpdater.cpp

@@ -52,7 +52,7 @@ std::unique_ptr<facebook::fboss::FbossCtrlAsyncClient> createAgentClient(
   auto sock = folly::AsyncSocket::newSocket(eb, addr, kConnTimeout);
   sock->setSendTimeout(kSendTimeout);
   auto channel =
-      apache::thrift::HeaderClientChannel::newChannel(std::move(sock));
+      apache::thrift::RocketClientChannel::newChannel(std::move(sock));
   channel->setTimeout(kRecvTimeout);
 
   return std::make_unique<facebook::fboss::FbossCtrlAsyncClient>(