Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: RHOAI v6 migration #183

Open
nicolethoen opened this issue Aug 26, 2024 · 4 comments
Open

Support: RHOAI v6 migration #183

nicolethoen opened this issue Aug 26, 2024 · 4 comments
Assignees
Milestone

Comments

@nicolethoen
Copy link
Contributor

take @jeff-phillips-18 WIP PR and run with it. Any questions on where to look for overrides, Jeff can help point people in the right directions.

PRs could be opened again the WIP PR, or commits can be made directly into the PR, depending on level of comfort.

Once we've made significant progress on these updates, we will engage with UXD designers (likely Jenn Giardino and Simran Dhaliwal) to do a design review of the PR, to check that nothing is broken or poorly formatted following the migration.

@thatblindgeye thatblindgeye self-assigned this Aug 28, 2024
@thatblindgeye
Copy link
Collaborator

In AboutDialog, the styling of the Alert title looks off. Because it's rendered inside a Content component, there's margin-block-start styling being applied to the h4.pf-v6-c-alert__title element which pushes it down compared to the icon:
image

@thatblindgeye
Copy link
Collaborator

The custom Switch styling in frontend/src/app/App.scss needs to be updated, it's causing the Switch toggle to be misaligned due to the sizing update:

image

@andrew-ronaldson
Copy link

What is the status of this issue? Should we break this into a task list?

@thatblindgeye
Copy link
Collaborator

@andrew-ronaldson the initial updates had been made, as well as a few followup updates as Jeff has rebased his draft PR. Currently the state of things are:

  • product designers are finishing up with a UI review and any issues found will be reviewed and finalized for any recommendations at the end of their current sprint
  • as Jeff rebases his draft PR I'll continue checking if there's anything else needing update - FWIW the last couple of updates have been much smaller than the initial (2-5 files with very straight forward updates)
  • Jeff and I will basically be going through any issues found from the UI review and make updates as necessary. There's a jira epic tracking the UI review, and each child issue of that epic should have a Google doc linked within it that outlines issues the designers may have found
  • any major bugs found in the UI review designers will reach out to Jeff and/or I on Slack for more immediate attention - thus far from what I've seen this hasn't happened too much so far

@dlabaj dlabaj added this to the 2024.Q4 milestone Nov 6, 2024
@andrew-ronaldson andrew-ronaldson changed the title Update CSS Overrides and references to PF tokens in RHOAI + PF6 WIP PR Support: RHOAI v6 migration Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress - on schedule
Status: In Progress
Development

No branches or pull requests

5 participants
@dlabaj @nicolethoen @andrew-ronaldson @thatblindgeye and others