Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine tables #1560

Closed
evwilkin opened this issue Dec 2, 2019 · 2 comments
Closed

Refine tables #1560

evwilkin opened this issue Dec 2, 2019 · 2 comments

Comments

@evwilkin
Copy link
Member

evwilkin commented Dec 2, 2019

@rachael-phillips commented on Thu Nov 07 2019

Hey @redallen did we update the tables? Can we talk about next steps on how to make the tables unified and not broken.

Should be:
Screen Shot 2019-11-07 at 5 35 43 PM


@redallen commented on Fri Nov 08 2019

From #106:
It'd be difficult to change the Core docs table to a more dynamic React table like the "CSS Variables" table or like the "AlertActionCloseButton" table, but it's possible.

For now, I've changed the React props tables to be like the "CSS Variables" tables. Come next site release we can talk about what other refinements we want.

@evwilkin evwilkin added this to the Prioritized backlog milestone Dec 2, 2019
@redallen
Copy link
Collaborator

Tables seem to be a constant struggle @rachael-phillips . Currently for React they have a max-width of calc(100vw - 418px) and fit the content of the "name" column:
image.png

For core, we use our normal HTML table without fitting columns, without a background, and a max-width of 680px:
image.png

Our core tables also do not always have the same headers or columns, so we can't make many assumptions about the content.

We could investigate making our HTML tables look like our React tables. We can style them however we want. What design do we want @rachael-phillips ?

@redallen
Copy link
Collaborator

Closing in favor of #1808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants