Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jump-links): landmark label #2870

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(jump-links): landmark label #2870

wants to merge 4 commits into from

Conversation

bennypowers
Copy link
Member

Closes #2860

What I did

  1. add aria-labelledby="label" to the nav landmark element

Testing Instructions

  1. confirm that screen readers read the page correctly

Notes to Reviewers

  1. Note that the listbox is already labelled by the same element.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a8397ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 27, 2024 •
edited
Loading

✅ Commitlint tests passed!

More Info 
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(jump-links): landmark label"
}

@netlify Netlify
Copy link

netlify bot commented Oct 27, 2024 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 3a5d314
😎 Deploy Preview https://deploy-preview-2870--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Oct 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

SSR Test Run for af81208: Report

@adamjohnson adamjohnson self-requested a review October 28, 2024 20:27
adamjohnson
adamjohnson reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed you assigned this to Greg and I. Was that intentional or did you want us to be reviewers?

Happy to take this up if applicable.

elements/pf-jump-links/pf-jump-links.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

SSR Test Run for 9c8154f: Report

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@bennypowers bennypowers enabled auto-merge (squash) November 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjohnson adamjohnson adamjohnson left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@adamjohnson adamjohnson

@hellogreg hellogreg

Labels
AT passed Automated testing has passed
Projects
None yet
Milestone
No milestone
3 participants
@bennypowers @adamjohnson @hellogreg