Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropdown: toggle and item target size #2670

Open
nikkimk opened this issue Jan 19, 2024 · 2 comments
Open

dropdown: toggle and item target size #2670

nikkimk opened this issue Jan 19, 2024 · 2 comments
Labels
accessibility Improve accessibility bug

Comments

@nikkimk
Copy link
Collaborator

nikkimk commented Jan 19, 2024

Description of the issue

Dropdown toggle button and item target sizes should be a 24px minimum, or WCAG 2.2 2.5.8 AA compliant.

Impacted component(s)

  • pf-dropdown
  • pf-dropdown-item

Steps to reproduce

  1. Go to Dropdown documentation
  2. Inspect the toggle button.
  3. Inspect the items.

Expected behavior

Minimum width and height should be 24px.
@nikkimk nikkimk added accessibility Improve accessibility bug labels Jan 19, 2024
@bennypowers
Copy link
Member

we can't diverge from upstream styles. a11y issues on pf should be filed there

@bennypowers
Copy link
Member

@nikkimk can we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Improve accessibility bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bennypowers @nikkimk