Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1:1]: pf-checkbox #2574

Open
bennypowers opened this issue Aug 7, 2023 · 1 comment · May be fixed by #2608
Open

[1:1]: pf-checkbox #2574

bennypowers opened this issue Aug 7, 2023 · 1 comment · May be fixed by #2608
Assignees
@bennypowers
Labels
1:1 Aligning components with PatternFly v4 design system Updates or issues to align components to the Red Hat Design System. new component request pfe 2.5 For PFE version 2.5 priority: low Severity level: 3

Comments

@bennypowers
Copy link
Member

Component name: <pf-checkbox>

General description of the component goal.

Design specification

http://v4-archive.patternfly.org/v4/components/checkbox/

Accessibility

FACE with shadow label and label attribute; we will consider it a violation to use a sibling label along with the label attribute.

slots will be provided for body and description content, as well as controlled checkboxes
@bennypowers bennypowers added new component request priority: low Severity level: 3 design system Updates or issues to align components to the Red Hat Design System. 1:1 Aligning components with PatternFly v4 labels Aug 7, 2023
@bennypowers bennypowers self-assigned this Aug 7, 2023
@bennypowers bennypowers added this to the PatternFly Elements 3 milestone Oct 18, 2023
@markcaron markcaron added the pfe 2.5 For PFE version 2.5 label Oct 19, 2023
@bennypowers bennypowers linked a pull request Oct 20, 2023 that will close this issue
feat(checkbox): add pf-checkbox #2608
Draft
@bennypowers bennypowers removed this from the PatternFly Elements 3 milestone Dec 4, 2023
@bennypowers
Copy link
Member Author

let's defer this until after 3.0 because of cross-root aria concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennypowers bennypowers

Labels
1:1 Aligning components with PatternFly v4 design system Updates or issues to align components to the Red Hat Design System. new component request pfe 2.5 For PFE version 2.5 priority: low Severity level: 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(checkbox): add pf-checkbox patternfly/patternfly-elements
2 participants
@bennypowers @markcaron