Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Array for patternDir #32

Open
dmolsen opened this issue May 17, 2016 · 6 comments
Open

Support Array for patternDir #32

dmolsen opened this issue May 17, 2016 · 6 comments
Assignees
@EvanLovely
Labels
enhancement needs spec approval v3.x

Comments

@dmolsen
Copy link
Member

dmolsen commented May 17, 2016

sourceDir (or sourceDirs) should be able to be defined as an array as a package creator may place assets in different locations.
@dmolsen dmolsen self-assigned this May 17, 2016
@dmolsen dmolsen mentioned this issue May 17, 2016
Open
@EvanLovely
Copy link
Member

Been wanting this for awhile; it'd be really helpful! Wouldn't we want an array of source/_patterns/ directories though? An array of sourceDirs could result in multiple _data/data.jsons; how would that get handled, merging?

@dmolsen dmolsen changed the title Support Array for sourceDir Support Array for patternDir May 17, 2016
@dmolsen
Copy link
Member Author

dmolsen commented May 17, 2016

You're correct. I've updated the title of the ticket to reflect that. Just got focused on the *Dir options that are available and patternDir isn't among them. Guess it needs to be :)

@dmolsen dmolsen added v2.x v3.x and removed v2.x labels Aug 5, 2016
@EvanLovely EvanLovely assigned EvanLovely and unassigned dmolsen Oct 12, 2017
@EvanLovely EvanLovely mentioned this issue Nov 2, 2017
Closed
@sghoweri sghoweri assigned sghoweri and unassigned sghoweri Nov 2, 2017
@sghoweri
Copy link
Contributor

sghoweri commented Nov 2, 2017

@EvanLovely need any help tackling this?

@EvanLovely
Copy link
Member

@sghoweri Sure! I feel like #35 is a prerequisite though.

@sghoweri
Copy link
Contributor

sghoweri commented Nov 2, 2017

@EvanLovely Ohhhh sorry - missed that. Need help on that one then?

@EvanLovely
Copy link
Member

@sghoweri Would love it! Got a PR started: #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanLovely EvanLovely

Labels
enhancement needs spec approval v3.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmolsen @EvanLovely @sghoweri