Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up / Normalize Parsing JSON / Yaml Data #146

Open
sghoweri opened this issue Oct 28, 2017 · 0 comments
Open

Clean up / Normalize Parsing JSON / Yaml Data #146

sghoweri opened this issue Oct 28, 2017 · 0 comments

Comments

@sghoweri
Copy link
Contributor

I was putting together a PR for more helpful JSON error messages when I noticed that we seem to have a bunch of virtually identical but still different ways of reading JSON or YAML data + checking for errors.

For example:
patterninforule_php_ _untitled__workspace_

data_php_ _untitled__workspace_

pseudopatternrule_php

pseudopatternrule_php_ _untitled__workspace_

@EvanLovely thoughts on trying to stick to some consistant variable names here -- maybe even just pull this chunk out into it's own function (pass the file to read in -- return the decoded data)? Could even lead to supporting other data formats if this single function got updated...

sghoweri pushed a commit that referenced this issue Oct 28, 2017
…clarity -- passing in the actual filename + path to the JSON and YAML data functions so errors are more helpful. Related to #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant