-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Lab only loads the pattern engines from the config #1256
Conversation
…llback to scanning node_modules
52d52ac
to
5d376a5
Compare
I can not approve that PR at the moment. The preview is not building. Pattern Engine undefined: good to go |
When I add engine mustache, it is working. (We need to get rid of that engine to be required everywhere but it's part of the UI-kit) But it still messages:
|
It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks! |
…ly, but not publicly facing any more
@ringods first of all thanks a lot for your work that you did so far regarding this topic. I tried to follow up on the feedback by @JosefBredereck and checked in some minor changes of how I would think about solving this topic. I hope that was in your interest. I've integrated some workarounds, that we should be able to remove with #1455; as even also mentioned by @JosefBredereck we should get rid of mustache in favour of its successor handlebars anyhow. |
if (enginesInConfig) { | ||
// Quick fix until we've removed @pattern-lab/engine-mustache, starting with https://github.com/pattern-lab/patternlab-node/issues/1239 | ||
// @TODO: Remove after removing @pattern-lab/engine-mustache dependency | ||
enginesInConfig.mustache = enginesInConfig.mustache || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach. Do we need to change this to handlebars after you changed the package with #1456?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mainly a mitigation, because we still need the mustache engine as we reference mustache templates all over the place, and without it we would get errors like that the header isn't available. By #1455 we should be able to remove this code part again.
Closes #1251
Summary of changes:
node_modules
if no engines are configuredengines
property in the Pattern Lab config file. URLs in the source code should point to this property once it is published during the release.